Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use faster hash algorithm when loading and saving a module #4372

Merged
merged 4 commits into from
Dec 22, 2023
Merged

use faster hash algorithm when loading and saving a module #4372

merged 4 commits into from
Dec 22, 2023

Conversation

maminrayej
Copy link
Contributor

Uses xxhash instead of sha256 to save and load a module from the local filesystem cache.
This should substantially improve the startup time of running a cached package.

before:

$ time wasmer run python -- --version

Python 3.12.0

real    0m2.749s
user    0m0.192s
sys     0m0.216s

after:

$ time wasmer run python -- --version

Python 3.12.0

real    0m0.284s
user    0m0.083s
sys     0m0.202s

@syrusakbary syrusakbary disabled auto-merge December 22, 2023 13:01
@syrusakbary syrusakbary merged commit 1b803c9 into master Dec 22, 2023
52 checks passed
@syrusakbary syrusakbary deleted the use-faster-hash branch December 22, 2023 14:43
@maminrayej maminrayej mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@syrusakbary syrusakbary syrusakbary approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maminrayej @syrusakbary